PCD-8825: ignoring PF9 build/patch numbers don't count as a mismatch - #20
Merged
Conversation
c-nilesh1984
requested review from
maheshbaviskar,
psarwate,
sharma-tapas and
srinivaschavan
August 3, 2026 11:40
psarwate
reviewed
Aug 3, 2026
| * If no ".pf9" marker is found, returns an unmodified copy. The caller | ||
| * must free the returned value. */ | ||
| static char * | ||
| ovn_version_base(const char *version) |
Collaborator
There was a problem hiding this comment.
nit: would it make more sense to rename function itself as pf9_ovn_version_base?
Rest code looks good. approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested manually
On host ovn version
2026-08-03T10:48:17.632Z|00004|main|INFO|OVN internal version is : [24.03.6.pf9.2026.9.0.500-20.33.0-76.8]
2026-08-03T10:48:17.632Z|00005|main|INFO|OVS IDL reconnected, force recompute.
2026-08-03T10:48:17.632Z|00006|reconnect|INFO|tcp:127.0.0.1:6642: connecting...
2026-08-03T10:48:17.632Z|00007|main|INFO|OVNSB IDL reconnected, force recompute.
2026-08-03T10:48:17.632Z|00008|reconnect|INFO|tcp:127.0.0.1:6642: connected
2026-08-03T10:48:17.632Z|00001|pinctrl(ovn_pinctrl0)|INFO|unix:/var/run/openvswitch/br-int.mgmt: connecting to switch
2026-08-03T10:48:17.632Z|00002|rconn(ovn_pinctrl0)|INFO|unix:/var/run/openvswitch/br-int.mgmt: connecting...
2026-08-03T10:48:17.633Z|00003|rconn(ovn_pinctrl0)|INFO|unix:/var/run/openvswitch/br-int.mgmt: connected
2026-08-03T10:48:17.789Z|00009|main|INFO|OVS feature set changed, force recompute.
2026-08-03T10:48:17.789Z|00010|ofctrl|INFO|unix:/var/run/openvswitch/br-int.mgmt: connecting to switch
2026-08-03T10:48:17.789Z|00011|rconn|INFO|unix:/var/run/openvswitch/br-int.mgmt: connecting...
2026-08-03T10:48:17.789Z|00012|rconn|INFO|unix:/var/run/openvswitch/br-int.mgmt: connected
2026-08-03T10:48:17.789Z|00013|main|INFO|OVS OpenFlow connection reconnected,force recompute.
2026-08-03T10:48:17.795Z|00001|statctrl(ovn_statctrl3)|INFO|unix:/var/run/openvswitch/br-int.mgmt: connecting to switch
2026-08-03T10:48:17.795Z|00002|rconn(ovn_statctrl3)|INFO|unix:/var/run/openvswitch/br-int.mgmt: connecting...
2026-08-03T10:48:17.796Z|00003|rconn(ovn_statctrl3)|INFO|unix:/var/run/openvswitch/br-int.mgmt: connected
2026-08-03T10:48:58.884Z|00014|memory|INFO|11104 kB peak resident set size after 41.3 seconds
2026-08-03T10:48:58.884Z|00015|memory|INFO|idl-cells-OVN_Southbound:1957 idl-cells-Open_vSwitch:1634 ofctrl_desired_flow_usage-KB:7 ofctrl_installed_flow_usage-KB:6 ofctrl_sb_flow_ref_usage-KB:3
On Du OVN-SB
root@ovn-ovsdb-sb-0:~# ovn-sbctl -V
ovn-sbctl 24.03.6.pf9.2026.8.0.497
Open vSwitch Library 3.3.6+pf9
DB Schema 20.33.0
Now Ovn check ignore the PF9 sub version , it just check ovn + DB schema version